Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 144003015: Revert of Fixes _NET_ACTIVE_WINDOW support check in order to not always return no. (Closed)

Created:
6 years, 11 months ago by Mattias Nissler (ping if slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@aura_deactivate
Visibility:
Public.

Description

Revert of Fixes _NET_ACTIVE_WINDOW support check in order to not always return no. (https://codereview.chromium.org/138903007/) Reason for revert: Speculative revert for DesktopScreenX11Test.GetWindowAtScreenPoint test failure on Linux Aura Tests bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20Aura%20Tests/builds/814/steps/views_unittests/logs/stdio [ RUN ] DesktopScreenX11Test.GetWindowAtScreenPoint Xlib: extension "RANDR" missing on display ":9". ../../ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc:227: Failure Value of: screen()->GetWindowAtScreenPoint(gfx::Point(115, 115)) Actual: 0x7f84f619fc00 Expected: window_three->GetNativeWindow() Which is: 0x1fbfcfb82200 [ FAILED ] DesktopScreenX11Test.GetWindowAtScreenPoint (82 ms) Original issue's description: > Fixes _NET_ACTIVE_WINDOW support check in order to not always return no. > > The check is currently not working on Unity because it expects an array > of atoms instead of one XID. With this patch, Unity is correctly seen > as supporting the feature. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246270 TBR=erg@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 2 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of Fixes _NET_ACTIVE_WINDOW support check in order to not always return no.
6 years, 11 months ago (2014-01-22 13:12:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/144003015/1
6 years, 11 months ago (2014-01-22 13:12:32 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 13:12:42 UTC) #3
Message was sent while issue was closed.
Change committed as 246309

Powered by Google App Engine
This is Rietveld 408576698