Issue 144003010: android envsetup: Remove a block that has no effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144003010: android envsetup: Remove a block that has no effect. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Remove a block that has no effect. By the time this runs, DEFINES has already been copied into GYP_DEFINES (see also r246062) and no longer has any effect. (Also, I didn't find references to CHROME_ANDROID_VALGRIND_BUILD on cs.chromium.org and the two internal places I looked.) BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246096

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/144003010/1

6 years, 11 months ago (2014-01-21 19:51:24 UTC) #3

Nico

6 years, 11 months ago (2014-01-21 20:06:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r246096 (presubmit successful).

Expand Messages | Collapse Messages