tools/perf/metrics/power.py - Issue 1440013002: [Android][Telemetry] Add logging and temporarily ensure StopMonitoringPower is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/power.py

Issue 1440013002: [Android][Telemetry] Add logging and temporarily ensure StopMonitoringPower is called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/power.py

diff --git a/tools/perf/metrics/power.py b/tools/perf/metrics/power.py

index 51756bbee921316959e1c7359e59826a851aa7b1..f19d16188aa8cad782c7ad30c218161b5010526f 100644

--- a/tools/perf/metrics/power.py

+++ b/tools/perf/metrics/power.py

@@ -91,6 +91,8 @@ class PowerMetric(Metric):

self._StopInternal()

def Close(self):

+ # TODO(rnephew): Remove when crbug.com/553601 is solved.

+ logging.info('Closing power monitors')

if self._platform.IsMonitoringPower():

self._platform.StopMonitoringPower()

« no previous file with comments | « tools/perf/measurements/memory.py ('k') | tools/telemetry/telemetry/core/platform.py » ('j') | no next file with comments »