Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1440013002: [Android][Telemetry] Add logging and temporarily ensure StopMonitoringPower is called. (Closed)

Created:
5 years, 1 month ago by rnephew (Reviews Here)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android][Telemetry] Add logging and temporarily ensure StopMonitoringPower is called. Temporary means of ensuring StopMonitoringPower is called to not impede test runs while figuring out how to solve root cause. BUG=553601 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/41f34441e69220c7991c122f64d5e689e709f237 Cr-Commit-Position: refs/heads/master@{#359481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M tools/perf/measurements/memory.py View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/perf/metrics/power.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/power_monitor_controller.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
rnephew (Reviews Here)
5 years, 1 month ago (2015-11-12 19:11:37 UTC) #2
nednguyen
lgtm
5 years, 1 month ago (2015-11-12 22:43:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440013002/1
5 years, 1 month ago (2015-11-12 22:45:08 UTC) #5
alexandermont
lgtm
5 years, 1 month ago (2015-11-12 23:03:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/4659)
5 years, 1 month ago (2015-11-13 02:33:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440013002/1
5 years, 1 month ago (2015-11-13 02:45:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 02:54:25 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 02:55:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41f34441e69220c7991c122f64d5e689e709f237
Cr-Commit-Position: refs/heads/master@{#359481}

Powered by Google App Engine
This is Rietveld 408576698