tools/dom/scripts/htmldartgenerator.py - Issue 14400004: First try at removing ? from HTML.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 14400004: First try at removing ? from HTML. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reverted stupid things. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index 8c2699269c03a01b0eaebc69855a67e0cf6e5464..55dfa25b26b313afdece57f855dead16dd0a31f9 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -390,7 +390,7 @@ class HtmlDartGenerator(object):

for index, param_info in enumerate(constructor_info.param_infos):

Anton Muhin 2013/04/30 12:55:13 I believe you should revert an order of iteration

blois 2013/05/03 15:59:24 Has this been resolved?

if param_info.is_optional:

dispatcher_emitter.Emit(

- ' if (!?$OPT_PARAM_NAME) {\n'

+ ' if ($OPT_PARAM_NAME == null) {\n'

' return $FACTORY._create($FACTORY_PARAMS);\n'

' }\n',

OPT_PARAM_NAME=param_info.name,