Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: mojo/dart/test/ping_pong_test.dart

Issue 1439993003: Dart: Avoid MojoResult and MojoHandleSignals constructors. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Small fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/test/ping_pong_test.dart
diff --git a/mojo/dart/test/ping_pong_test.dart b/mojo/dart/test/ping_pong_test.dart
index 7701419b93276b9329b3b380e097a370d9b9ef3f..5730c511c0b6640bf3cc3fc04fbe036d74cfb863 100644
--- a/mojo/dart/test/ping_pong_test.dart
+++ b/mojo/dart/test/ping_pong_test.dart
@@ -38,16 +38,16 @@ void expectStringFromEndpoint(
void pipeTestIsolate(core.MojoMessagePipeEndpoint endpoint) {
var eventSubscription = new core.MojoEventSubscription(endpoint.handle);
eventSubscription.subscribe((List<int> event) {
- var mojoSignals = new core.MojoHandleSignals(event[1]);
- if (mojoSignals.isReadWrite) {
+ int mojoSignals = event[1];
+ if (core.MojoHandleSignals.isReadWrite(mojoSignals)) {
throw 'We should only be reading or writing, not both.';
- } else if (mojoSignals.isReadable) {
+ } else if (core.MojoHandleSignals.isReadable(mojoSignals)) {
expectStringFromEndpoint("Ping", endpoint);
eventSubscription.enableWriteEvents();
- } else if (mojoSignals.isWritable) {
+ } else if (core.MojoHandleSignals.isWritable(mojoSignals)) {
endpoint.write(byteDataOfString("Pong"));
eventSubscription.enableReadEvents();
- } else if (mojoSignals.isPeerClosed) {
+ } else if (core.MojoHandleSignals.isPeerClosed(mojoSignals)) {
eventSubscription.close();
} else {
throw 'Unexpected event.';
@@ -61,16 +61,16 @@ main() {
var eventSubscription = new core.MojoEventSubscription(endpoint.handle);
Isolate.spawn(pipeTestIsolate, pipe.endpoints[1]).then((_) {
eventSubscription.subscribe((List<int> event) {
- var mojoSignals = new core.MojoHandleSignals(event[1]);
- if (mojoSignals.isReadWrite) {
+ int mojoSignals = event[1];
+ if (core.MojoHandleSignals.isReadWrite(mojoSignals)) {
throw 'We should only be reading or writing, not both.';
- } else if (mojoSignals.isReadable) {
+ } else if (core.MojoHandleSignals.isReadable(mojoSignals)) {
expectStringFromEndpoint("Pong", endpoint);
eventSubscription.close();
- } else if (mojoSignals.isWritable) {
+ } else if (core.MojoHandleSignals.isWritable(mojoSignals)) {
endpoint.write(byteDataOfString("Ping"));
eventSubscription.enableReadEvents();
- } else if (mojoSignals.isPeerClosed) {
+ } else if (core.MojoHandleSignals.isPeerClosed(mojoSignals)) {
throw 'This end should close first.';
} else {
throw 'Unexpected event.';

Powered by Google App Engine
This is Rietveld 408576698