Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: mojo/dart/packages/mojo/lib/src/stub.dart

Issue 1439993003: Dart: Avoid MojoResult and MojoHandleSignals constructors. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Small fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo/lib/src/stub.dart
diff --git a/mojo/dart/packages/mojo/lib/src/stub.dart b/mojo/dart/packages/mojo/lib/src/stub.dart
index dce10388d67af4bda2dd89967035932d768378c6..ea09ae36467a34445595c894463a681ec68e9f45 100644
--- a/mojo/dart/packages/mojo/lib/src/stub.dart
+++ b/mojo/dart/packages/mojo/lib/src/stub.dart
@@ -69,7 +69,8 @@ abstract class Stub extends core.MojoEventHandler {
// FailedPrecondition is only used to indicate that the other end of
// the pipe has been closed. We can ignore the close here and wait for
// the PeerClosed signal on the event stream.
- assert(endpoint.status.isOk || endpoint.status.isFailedPrecondition);
+ assert((endpoint.status == core.MojoResult.kOk) ||
+ (endpoint.status == core.MojoResult.kFailedPrecondition));
Cutch 2015/11/17 00:01:51 Indentation on line 73
zra 2015/11/17 14:57:29 Unfortunately, this is the result of the Dart form
if (_isClosing && (_outstandingResponseFutures == 0)) {
// This was the final response future for which we needed to send
// a response. It is safe to close.

Powered by Google App Engine
This is Rietveld 408576698