Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: content/renderer/media/mock_peer_connection_impl.h

Issue 1439973006: Reland Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js.… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug and add expectation. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/media/rtc_peer_connection_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_
6 #define CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_ 6 #define CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 return PeerConnectionInterface::kIceNew; 54 return PeerConnectionInterface::kIceNew;
55 } 55 }
56 IceConnectionState ice_connection_state() override { 56 IceConnectionState ice_connection_state() override {
57 NOTIMPLEMENTED(); 57 NOTIMPLEMENTED();
58 return PeerConnectionInterface::kIceConnectionNew; 58 return PeerConnectionInterface::kIceConnectionNew;
59 } 59 }
60 IceGatheringState ice_gathering_state() override { 60 IceGatheringState ice_gathering_state() override {
61 NOTIMPLEMENTED(); 61 NOTIMPLEMENTED();
62 return PeerConnectionInterface::kIceGatheringNew; 62 return PeerConnectionInterface::kIceGatheringNew;
63 } 63 }
64 void Close() override { 64
65 NOTIMPLEMENTED(); 65 MOCK_METHOD0(Close, void());
66 }
67 66
68 const webrtc::SessionDescriptionInterface* local_description() const override; 67 const webrtc::SessionDescriptionInterface* local_description() const override;
69 const webrtc::SessionDescriptionInterface* remote_description() 68 const webrtc::SessionDescriptionInterface* remote_description()
70 const override; 69 const override;
71 70
72 // JSEP01 APIs 71 // JSEP01 APIs
73 void CreateOffer( 72 void CreateOffer(
74 webrtc::CreateSessionDescriptionObserver* observer, 73 webrtc::CreateSessionDescriptionObserver* observer,
75 const webrtc::MediaConstraintsInterface* constraints) override; 74 const webrtc::MediaConstraintsInterface* constraints) override;
76 void CreateAnswer( 75 void CreateAnswer(
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 int sdp_mline_index_; 131 int sdp_mline_index_;
133 std::string ice_sdp_; 132 std::string ice_sdp_;
134 webrtc::PeerConnectionObserver* observer_; 133 webrtc::PeerConnectionObserver* observer_;
135 134
136 DISALLOW_COPY_AND_ASSIGN(MockPeerConnectionImpl); 135 DISALLOW_COPY_AND_ASSIGN(MockPeerConnectionImpl);
137 }; 136 };
138 137
139 } // namespace content 138 } // namespace content
140 139
141 #endif // CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_ 140 #endif // CONTENT_RENDERER_MEDIA_MOCK_PEER_CONNECTION_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/rtc_peer_connection_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698