Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 1439973005: Remove navigator.getStorageUpdates() (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
michaelbai, Mike West
CC:
android-webview-reviews_chromium.org, blink-reviews, Inactive, chromium-reviews, timvolodine, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove navigator.getStorageUpdates() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ak1kVjiX9T4/mo1rqcyQAQAJ navigator.yieldForStorageUpdates() will be removed from the spec: https://github.com/whatwg/html/pull/342 BUG=465255 Committed: https://crrev.com/44d28d7eeafa1f91a1a947f750e9ffd46ce49ceb Cr-Commit-Position: refs/heads/master@{#360140}

Patch Set 1 #

Patch Set 2 : revert NavigatorCookies change #

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439973005/1
5 years, 1 month ago (2015-11-14 15:34:39 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/140877)
5 years, 1 month ago (2015-11-14 17:54:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439973005/20001
5 years, 1 month ago (2015-11-17 12:03:01 UTC) #6
philipj_slow
PTAL
5 years, 1 month ago (2015-11-17 12:04:18 UTC) #8
philipj_slow
michaelbai@, it looks like timvolodine@ is OOO for a while, can you review in android_webview/ ...
5 years, 1 month ago (2015-11-17 12:39:19 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 13:04:18 UTC) #12
michaelbai
android_webview lgtm
5 years, 1 month ago (2015-11-17 18:43:03 UTC) #13
Mike West
LGTM.
5 years, 1 month ago (2015-11-17 18:46:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439973005/20001
5 years, 1 month ago (2015-11-17 19:53:22 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 19:59:34 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:00:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44d28d7eeafa1f91a1a947f750e9ffd46ce49ceb
Cr-Commit-Position: refs/heads/master@{#360140}

Powered by Google App Engine
This is Rietveld 408576698