[PoC] Reformat all BUILD.gn and *.gni files with new gn.

[PoC] Reformat all BUILD.gn and *.gni files with new gn.

This new version of gn is build with http://crrev.com/1442023002
and sort all "deps" lists.

Automated CL using the following commands:
$ git ls-files "*.gn" "*.gni" | grep -v format_test_data | sed "s/^/gn format --in-place /" > script && sh script

BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[scottmg, 2015-11-16 17:39:41]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-11-16 17:39:42]

https://codereview.chromium.org/1439973004/diff/60001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1439973004/diff/60001/BUILD.gn#oldcode477
BUILD.gn:477: "//third_party/codesighs:nm2tsv",
I think the blank lines were being used intentionally to separate blocks of deps
here.

https://codereview.chromium.org/1439973004/diff/60001/third_party/freetype-an...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/1439973004/diff/60001/third_party/freetype-an...
third_party/freetype-android/BUILD.gn:18: "src/src/autofit/autofit.c",
This should probably be reverted based on the comment.

[sdefresne, 2015-11-16 20:47:44]

Updated with latest version of gn patch that also sort public_deps.

This is still not for commit. I think we should make individual CLs instead.

[scottmg, 2015-11-16 21:19:54]

Phew! lgtm

https://codereview.chromium.org/1439973004/diff/80001/third_party/freetype-an...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/1439973004/diff/80001/third_party/freetype-an...
third_party/freetype-android/BUILD.gn:17: # same order as in Android.mk to ease
maintenance.
I think you should revert this file. Maybe sort whatever Android.mk is and this
in a standalone change.

[scottmg, 2015-11-16 21:29:57]

(Oh, and remove [PoC] from the title to make it seem more official. :)

[tfarina, 2015-11-16 21:35:02]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-11-16 21:35:03]

Sylvain, have you ran the following commands lines?

$ git ls-files "*.gn "*.gni" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh"

If you used that or other command, do you mind including it on the CL
description? So it is easier for others in future (me?) to do another pass ;)

[sdefresne, 2015-11-17 09:10:29]

Description was changed from

==========
[PoC] Reformat all BUILD.gn and *.gni files with new gn.

This new version of gn is build with http://crrev.com/1442023002
and sort all "deps" lists.

BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[PoC] Reformat all BUILD.gn and *.gni files with new gn.

This new version of gn is build with http://crrev.com/1442023002
and sort all "deps" lists.

Automated CL using the following commands:
$ git ls-files "*.gn" "*.gni" | grep -v format_test_data | sed "s/^/gn format
--in-place /" > script && sh script

BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========