net/test/url_request/url_request_failed_job.h - Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/url_request/url_request_failed_job.h

Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address David's comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/url_request/url_request_failed_job.h

diff --git a/net/test/url_request/url_request_failed_job.h b/net/test/url_request/url_request_failed_job.h

index 0413111c87c9516e3384ea22ced6925afc999783..45b1911edc86b167c2d09268929e5bfc0fc780f5 100644

--- a/net/test/url_request/url_request_failed_job.h

+++ b/net/test/url_request/url_request_failed_job.h

@@ -39,7 +39,7 @@ class URLRequestFailedJob : public URLRequestJob {

// URLRequestJob implementation:

void Start() override;

- bool ReadRawData(IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(IOBuffer* buf, int buf_size) override;

int GetResponseCode() const override;

void GetResponseInfo(HttpResponseInfo* info) override;

@@ -71,6 +71,7 @@ class URLRequestFailedJob : public URLRequestJob {

protected:

~URLRequestFailedJob() override;

+ void StartAsync();

private:

HttpResponseInfo response_info_;