content/browser/service_worker/service_worker_read_from_cache_job.h - Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job.h

Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address David's comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/net/view_http_cache_job_factory.cc ('k') | content/browser/service_worker/service_worker_read_from_cache_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_read_from_cache_job.h

diff --git a/content/browser/service_worker/service_worker_read_from_cache_job.h b/content/browser/service_worker/service_worker_read_from_cache_job.h

index fccde7abe60fbdb53bfb47cb27ecbfe223bc706d..a62893d55fc48ce580fb2ae20633fd39f092e57a 100644

--- a/content/browser/service_worker/service_worker_read_from_cache_job.h

+++ b/content/browser/service_worker/service_worker_read_from_cache_job.h

@@ -51,13 +51,14 @@ class CONTENT_EXPORT ServiceWorkerReadFromCacheJob

void GetResponseInfo(net::HttpResponseInfo* info) override;

int GetResponseCode() const override;

void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;

- bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(net::IOBuffer* buf, int buf_size) override;

// Reader completion callbacks.

void OnReadInfoComplete(int result);

void OnReadComplete(int result);

// Helpers

+ void StartAsync();

const net::HttpResponseInfo* http_info() const;

bool is_range_request() const { return range_requested_.IsValid(); }

void SetupRangeResponse(int response_data_size);