content/browser/appcache/appcache_url_request_job.h - Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_url_request_job.h

Issue 1439953006: Reland: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address David's comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_url_request_job.h

diff --git a/content/browser/appcache/appcache_url_request_job.h b/content/browser/appcache/appcache_url_request_job.h

index 95a3e18310ed7b9bd44e5ddf59c8f6415826fc8c..8f51e7b6ebdc4978fe38a7331735a71de1686bee 100644

--- a/content/browser/appcache/appcache_url_request_job.h

+++ b/content/browser/appcache/appcache_url_request_job.h

@@ -148,7 +148,7 @@ class CONTENT_EXPORT AppCacheURLRequestJob

net::LoadState GetLoadState() const override;

bool GetCharset(std::string* charset) override;

void GetResponseInfo(net::HttpResponseInfo* info) override;

- bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(net::IOBuffer* buf, int buf_size) override;

// Sets extra request headers for Job types that support request headers.

// This is how we get informed of range-requests.