Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1439953002: Use debug apks for dev builds. (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use debuggable apks for dev builds. This will allow to use our dev workflow on non rooted device. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3b02af69d853f9de63224b944377182a6148cb5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/android/lint/suppressions.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M shell/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M shell/android/apk/AndroidManifest.xml.jinja2 View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
qsr
5 years, 1 month ago (2015-11-12 13:45:44 UTC) #1
ppi
Please s/debug/debuggable/ in the first line of the commit message. Please indicate the reason for ...
5 years, 1 month ago (2015-11-12 14:28:39 UTC) #2
qsr
5 years, 1 month ago (2015-11-12 14:46:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b02af69d853f9de63224b944377182a6148cb5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698