Issue 143993006: Remove applyAuthorStyles flag from ShadowRoot.

Issue 143993006: Remove applyAuthorStyles flag from ShadowRoot. (Closed)

Created:
6 years, 11 months ago by hayato

Modified:
6 years, 11 months ago

Reviewers:
tasak (please_use_google.com), esprehn, dglazkov

CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove applyAuthorStyles flag from ShadowRoot. Removing applyAuthorStyles flag from ShadowRoot's IDL. We defer the internal clean up because the style resolver still depends on the implementation of applyAuthorStyles. BUG=323130 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165673

Patch Set 1 #

Patch Set 2 : Fix unit tests and suppress w3c tests. #

Patch Set 3 : Rebase to resolve conflict TestExpectation #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -663 lines)			Patch
LayoutTests/TestExpectations	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html	View		1 chunk	+0 lines, -243 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt	View		1 chunk	+0 lines, -36 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-nested.html	View		1 chunk	+0 lines, -17 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule.html	View		3 chunks	+0 lines, -33 lines	0 comments	Download
LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule-expected.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download
LayoutTests/fast/dom/shadow/host-wrapper-reclaimed.html	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope.html	View		1 chunk	+0 lines, -34 lines	0 comments	Download
LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope-expected.txt	View		1 chunk	+0 lines, -10 lines	0 comments	Download
LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content.html	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-distributed.html	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-nodes.html	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html	View		1 chunk	+0 lines, -150 lines	0 comments	Download
LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download
LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles.html	View		1 chunk	+0 lines, -84 lines	0 comments	Download
LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles-expected.txt	View		1 chunk	+0 lines, -15 lines	0 comments	Download
LayoutTests/fast/dom/shadow/shadowroot-keyframes.html	View		2 chunks	+0 lines, -10 lines	0 comments	Download
LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
Source/core/dom/shadow/ShadowRoot.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download
Source/web/tests/data/touch-action-tests.css	View	1	1 chunk	+1 line, -1 line	0 comments	Download
Source/web/tests/data/touch-action-tests.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dglazkov

lgtm, but there are still some failures in the w3c suite (I think?) and touch ...

6 years, 11 months ago (2014-01-22 18:21:01 UTC) #2

hayato

Thank you for the review. On 2014/01/22 18:21:01, Dimitri Glazkov wrote: > lgtm, but there ...

6 years, 11 months ago (2014-01-23 01:35:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/143993006/10016

6 years, 11 months ago (2014-01-23 03:18:12 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8854

6 years, 11 months ago (2014-01-23 06:45:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/143993006/160001

6 years, 11 months ago (2014-01-23 09:01:05 UTC) #6

Message was sent while issue was closed.

Change committed as 165673

Expand Messages | Collapse Messages