fix the bugs of getSyncParameter in gl-object-get-calls.html

Bridge getSynciv from Blink to command buffer. This small change
fixed the bugs of getSyncParameter in gl-object-get-calls.html.

BUG=527249
TEST=conformance2/state/gl-object-get-calls.html, gpu_unittests

Committed: https://crrev.com/43e079c690a18f498b205da0f00311f254318099
Cr-Commit-Position: refs/heads/master@{#360485}

[yunchao, 2015-11-13 09:48:23]

Description was changed from

==========
fix the bugs of getSyncParameter in gl-object-get-calls.js

BUG=295792
==========

to

==========
Bridge getSynciv from Blink to command buffer. This small change 
fixed the bugs of getSyncParameter in gl-object-get-calls.html. 

BUG=527249

TEST=conformance2/state/gl-object-get-calls.html, gpu_unittests
==========

[yunchao, 2015-11-13 09:48:24]

yunchao.he@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[yunchao, 2015-11-13 09:48:44]

PTAL. Thanks a lot!

[bajones, 2015-11-13 21:27:22]

LGTM, but I'm not an owner. We should do something to make these cases more
visible. :P

[piman, 2015-11-14 01:29:41]

lgtm

[yunchao, 2015-11-14 05:44:54]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-14 05:45:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439913005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439913005/1

[commit-bot: I haz the power, 2015-11-14 05:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-14 05:52:55]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2015-11-14 08:27:09]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-14 08:27:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439913005/20001

[commit-bot: I haz the power, 2015-11-14 09:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-14 09:01:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2015-11-18 02:58:12]

LGTM, though I think you should file a new bug since Issue 527249 has already
been marked fixed.

[yunchao, 2015-11-18 13:37:47]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 13:38:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439913005/20001

[yunchao, 2015-11-18 14:28:08]

On 2015/11/18 02:58:12, Ken Russell wrote:
> LGTM, though I think you should file a new bug since Issue 527249 has already
> been marked fixed.

Ken, what about mark Issue 527249 as "Assigned" or "Started" again? Some
conformance tests are added into gl-object-get-call.js by my intern recently.
The new added cases exposed bugs in the implementation of WebGL2 getters in
Chromium. I suppose that there still have some bugs even this one is fixed
(getUniformBlock*, getActiveUniform*, etc are not covered).

[yunchao, 2015-11-18 14:42:02]

On 2015/11/13 21:27:22, bajones wrote:
> LGTM, but I'm not an owner. We should do something to make these cases more
> visible. :P

Thanks for your review, Brandon. What do you mean "these cases", do you mean
cases those has implemented in both Blink WebGL and command buffer, but are not
bridged from Blink WebGL to command buffer, or getter APIs in WebGL 2 which are
not covered in WebGL 2 conformance test? Sorry, I didn't get it...

[commit-bot: I haz the power, 2015-11-18 14:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 14:54:53]

Dry run: This issue passed the CQ dry run.

[bajones, 2015-11-18 16:42:01]

On 2015/11/18 14:42:02, yunchao wrote:
> On 2015/11/13 21:27:22, bajones wrote:
> > LGTM, but I'm not an owner. We should do something to make these cases more
> > visible. :P
> 
> Thanks for your review, Brandon. What do you mean "these cases", do you mean
> cases those has implemented in both Blink WebGL and command buffer, but are
not
> bridged from Blink WebGL to command buffer, or getter APIs in WebGL 2 which
are
> not covered in WebGL 2 conformance test? Sorry, I didn't get it...

Sorry for not being clearer.I meant cases where a GL function exists in
WebGraphicsContext3D as a stub only, with no ovverride to wire it up to the
command buffer. We've seen a couple of similar problems that go undetected
longer than I'd like as a side effect of how we added the ES3 functions to the
interface. (That was prior to the blink merge, so adding functions with stub
implementations was the easy way to prevent compile failures).

[yunchao, 2015-11-19 00:10:20]

On 2015/11/18 16:42:01, bajones wrote:
> On 2015/11/18 14:42:02, yunchao wrote:
> > On 2015/11/13 21:27:22, bajones wrote:
> > > LGTM, but I'm not an owner. We should do something to make these cases
more
> > > visible. :P
> > 
> > Thanks for your review, Brandon. What do you mean "these cases", do you mean
> > cases those has implemented in both Blink WebGL and command buffer, but are
> not
> > bridged from Blink WebGL to command buffer, or getter APIs in WebGL 2 which
> are
> > not covered in WebGL 2 conformance test? Sorry, I didn't get it...
> 
> Sorry for not being clearer.I meant cases where a GL function exists in
> WebGraphicsContext3D as a stub only, with no ovverride to wire it up to the
> command buffer. We've seen a couple of similar problems that go undetected
> longer than I'd like as a side effect of how we added the ES3 functions to the
> interface. (That was prior to the blink merge, so adding functions with stub
> implementations was the easy way to prevent compile failures).

Yeah. Got it. Thanks for your explanation, Brandon. I will go through the APIs
in WGC3D to find out similar cases you said. Now Blink has merged into Chromium,
new APIs those will be added into WGC3D will not have the same issue, I think.

[yunchao, 2015-11-19 00:57:28]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2015-11-19 00:57:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
bajones@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1439913005/#ps20001
(title: "coding style")

[commit-bot: I haz the power, 2015-11-19 00:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439913005/20001

[commit-bot: I haz the power, 2015-11-19 02:11:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 02:12:23]

Patchset 2 (id:??) landed as
https://crrev.com/43e079c690a18f498b205da0f00311f254318099
Cr-Commit-Position: refs/heads/master@{#360485}

[Ken Russell (switch to Gerrit), 2015-11-19 02:21:51]

On 2015/11/18 14:28:08, yunchao wrote:
> On 2015/11/18 02:58:12, Ken Russell wrote:
> > LGTM, though I think you should file a new bug since Issue 527249 has
already
> > been marked fixed.
> 
> Ken, what about mark Issue 527249 as "Assigned" or "Started" again? Some
> conformance tests are added into gl-object-get-call.js by my intern recently.
> The new added cases exposed bugs in the implementation of WebGL2 getters in
> Chromium. I suppose that there still have some bugs even this one is fixed
> (getUniformBlock*, getActiveUniform*, etc are not covered).

I see. It's not that important. We can continue to reference Issue 527249 and
reopen it if new tests are added that fail temporarily.