Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 14399005: Added projection mode to touch HUD (Closed)

Created:
7 years, 8 months ago by mohsen
Modified:
7 years, 8 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Added projection mode to touch HUD Projection mode is useful in presentations when the screen is projected using a projector. In this mode, only active touch points are shown without any trails. BUG=233565 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196931

Patch Set 1 #

Patch Set 2 : Small typo corrected #

Total comments: 6

Patch Set 3 : Applied reviews #

Patch Set 4 : Used SkFloatToScalar to convert float to SkScalar (for win7_aura compile error) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -101 lines) Patch
M ash/touch/touch_observer_hud.h View 5 chunks +17 lines, -3 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 2 3 9 chunks +283 lines, -98 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mohsen
Please take a look...
7 years, 8 months ago (2013-04-25 17:38:01 UTC) #1
sadrul
https://codereview.chromium.org/14399005/diff/4001/ash/touch/touch_observer_hud.cc File ash/touch/touch_observer_hud.cc (right): https://codereview.chromium.org/14399005/diff/4001/ash/touch/touch_observer_hud.cc#newcode395 ash/touch/touch_observer_hud.cc:395: virtual void AnimationEnded(const ui::Animation* animation) { OVERRIDE https://codereview.chromium.org/14399005/diff/4001/ash/touch/touch_observer_hud.cc#newcode410 ash/touch/touch_observer_hud.cc:410: ...
7 years, 8 months ago (2013-04-26 16:17:24 UTC) #2
mohsen
https://codereview.chromium.org/14399005/diff/4001/ash/touch/touch_observer_hud.cc File ash/touch/touch_observer_hud.cc (right): https://codereview.chromium.org/14399005/diff/4001/ash/touch/touch_observer_hud.cc#newcode395 ash/touch/touch_observer_hud.cc:395: virtual void AnimationEnded(const ui::Animation* animation) { On 2013/04/26 16:17:24, ...
7 years, 8 months ago (2013-04-26 17:22:03 UTC) #3
sadrul
LGTM
7 years, 8 months ago (2013-04-26 17:29:38 UTC) #4
mohsen
sky@: for OWNERS in /ash/, please.
7 years, 8 months ago (2013-04-26 17:34:56 UTC) #5
sky
Rubber stamp LGTM as Sadrul reviewed it.
7 years, 8 months ago (2013-04-26 19:40:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/14399005/9003
7 years, 8 months ago (2013-04-26 19:41:35 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-26 20:47:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/14399005/15002
7 years, 8 months ago (2013-04-26 21:42:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, ...
7 years, 8 months ago (2013-04-26 21:53:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/14399005/15002
7 years, 8 months ago (2013-04-27 03:06:03 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-27 03:25:08 UTC) #12
Message was sent while issue was closed.
Change committed as 196931

Powered by Google App Engine
This is Rietveld 408576698