runtime/vm/disassembler.h - Issue 1439893002: - Annotate instructions that load objects from the ObjectPool or Thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler.h

Issue 1439893002: - Annotate instructions that load objects from the ObjectPool or Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler.h

diff --git a/runtime/vm/disassembler.h b/runtime/vm/disassembler.h

index 1becc4d1f1e4f63bcb92eae1c553ad210cb0073d..e89ab21000db6f7ec9f58b7bff8f4733183c74ae 100644

--- a/runtime/vm/disassembler.h

+++ b/runtime/vm/disassembler.h

@@ -24,7 +24,8 @@ class DisassemblyFormatter {

virtual ~DisassemblyFormatter() { }

// Consume the decoded instruction at the given pc.

- virtual void ConsumeInstruction(char* hex_buffer,

+ virtual void ConsumeInstruction(const Code& code,

+ char* hex_buffer,

intptr_t hex_size,

char* human_buffer,

intptr_t human_size,

@@ -42,7 +43,8 @@ class DisassembleToStdout : public DisassemblyFormatter {

DisassembleToStdout() : DisassemblyFormatter() { }

~DisassembleToStdout() { }

- virtual void ConsumeInstruction(char* hex_buffer,

+ virtual void ConsumeInstruction(const Code& code,

+ char* hex_buffer,

intptr_t hex_size,

char* human_buffer,

intptr_t human_size,

@@ -63,7 +65,8 @@ class DisassembleToJSONStream : public DisassemblyFormatter {

: DisassemblyFormatter(), jsarr_(jsarr) { }

~DisassembleToJSONStream() { }

- virtual void ConsumeInstruction(char* hex_buffer,

+ virtual void ConsumeInstruction(const Code& code,

+ char* hex_buffer,

intptr_t hex_size,

char* human_buffer,

intptr_t human_size,

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/disassembler.cc » ('j') | no next file with comments »