- Annotate instructions that load objects from the ObjectPool or Thread.

runtime/observatory/lib/src/elements/code_view.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_view_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
+import 'service_ref.dart';
 import 'package:observatory/app.dart';
 import 'package:observatory/service.dart';
 import 'package:observatory/cpu_profile.dart';
 import 'package:polymer/polymer.dart';
 
 class DisassemblyTable extends SortedTable {
   DisassemblyTable(columns) : super(columns);
 }
 
 class InlineTable extends SortedTable {
   InlineTable(columns) : super(columns);
 }
 
 @CustomTag('code-view')
 class CodeViewElement extends ObservatoryElement {
   @observable Code code;
   ProfileCode get profile => code == null ? null : code.profile;
   DisassemblyTable disassemblyTable;
   InlineTable inlineTable;
 
   CodeViewElement.created() : super.created() {
     // Create table models.
     var columns = [
         new SortedTableColumn('Address'),
         new SortedTableColumn('Inclusive'),
         new SortedTableColumn('Exclusive'),
         new SortedTableColumn('Disassembly'),
+        new SortedTableColumn('Objects'),
     ];
     disassemblyTable = new DisassemblyTable(columns);
     columns = [
         new SortedTableColumn('Address'),
         new SortedTableColumn('Inclusive'),
         new SortedTableColumn('Exclusive'),
         new SortedTableColumn('Functions'),
     ];
     inlineTable = new InlineTable(columns);
   }
@@ skipping 117 matching lines @@
 
   void _updateDiasssemblyTable() {
     disassemblyTable.clearRows();
     if (code == null) {
       return;
     }
     for (CodeInstruction instruction in code.instructions) {
       var row = [formattedAddress(instruction),
                  formattedInclusive(instruction),
                  formattedExclusive(instruction),
-                 instruction.human];
+                 instruction.human,
+                 instruction.object];
       disassemblyTable.addRow(new SortedTableRow(row));
     }
   }
 
   void _addDisassemblyDOMRow() {
     var tableBody = $['disassemblyTableBody'];
     assert(tableBody != null);
     var tr = new TableRowElement();
 
     var cell;
 
     // Add new space.
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
+    cell = tr.insertCell(-1);
+    cell.classes.add('monospace');
 
     tableBody.children.add(tr);
   }
 
   void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) {
     final row = disassemblyTable.rows[rowIndex];
     final n = row.values.length;
     for (var i = 0; i < n; i++) {
       final cell = tr.children[i];
-      cell.title = row.values[i].toString();
-      cell.text = row.values[i].toString();
+      final content = row.values[i];
+      if (content is ServiceObject) {
+        ServiceRefElement element = new Element.tag('any-service-ref');
+        element.ref = content;
+        cell.append(element);
+      } else if (content != null) {
+        cell.text = content.toString();
+      }
     }
   }
 
   void _updateDisassemblyDOMTable() {
     var tableBody = $['disassemblyTableBody'];
     assert(tableBody != null);
     // Resize DOM table.
     if (tableBody.children.length > disassemblyTable.sortedRows.length) {
       // Shrink the table.
       var deadRows =
@@ skipping 71 matching lines @@
       var addressRangeString = formattedAddressRange(interval);
       var addressRangeElement = new SpanElement();
       addressRangeElement.classes.add('monospace');
       addressRangeElement.text = addressRangeString;
       addressRangeCell.children.clear();
       addressRangeCell.children.add(addressRangeElement);
     }
 
     for (var i = addressRangeColumn + 1; i < columns - 1; i++) {
       var cell = tr.children[i];
-      cell.title = row.values[i].toString();
       cell.text = row.values[i].toString();
     }
     var functions = row.values[functionsColumn];
     var functionsCell = tr.children[functionsColumn];
     functionsCell.children.clear();
     for (var func in functions) {
       var functionRef = new Element.tag('function-ref');
       functionRef.ref = func;
       functionsCell.children.add(functionRef);
       var gap = new SpanElement();
@@ skipping 56 matching lines @@
   }
 
   void mouseOut(Event e, var detail, Node target) {
     var jt = _findJumpTarget(target);
     if (jt == null) {
       return;
     }
     jt.classes.remove('highlight');
   }
 }