PRESUBMIT.py - Issue 1439833002: Remove //third_party/wtl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1439833002: Remove //third_party/wtl. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index d7195a6d37af1d251949aa8b1df11887a71d3495..30f1151d063c220e3d934144f4726c57029eca89 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -463,9 +463,9 @@ def _CheckIncludeOrderInFile(input_api, f, changed_linenums):

# Exclude the following includes from the check:

# 1) #include <.../...>, e.g., <sys/...> includes often need to appear in a

# specific order.

- # 2) <atlbase.h>, "build/build_config.h"

+ # 2) "build/build_config.h"

excluded_include_pattern = input_api.re.compile(

- r'\s*#include (\<.*/.*|\<atlbase\.h\>|"build/build_config.h")')

+ r'\s*#include (\<.*/.*|"build/build_config.h")')

custom_include_pattern = input_api.re.compile(r'\s*#include "(?P<FILE>.*)"')

# Match the final or penultimate token if it is xxxtest so we can ignore it

# when considering the special first include.

« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »