Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 143983017: make GM self-test run gm/rebaseline_server unittests (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

make GM self-test run gm/rebaseline_server unittests Committed: http://code.google.com/p/skia/source/detail?r=13170

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M gm/rebaseline_server/test_all.py View 1 chunk +4 lines, -2 lines 0 comments Download
M gm/tests/run.sh View 3 chunks +9 lines, -4 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
epoger
Ready for review at patchset 1. https://codereview.chromium.org/143983017/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.chromium.org/143983017/diff/1/gm/tests/run.sh#newcode51 gm/tests/run.sh:51: echo "assert_passes $COMMAND ...
6 years, 11 months ago (2014-01-24 17:35:48 UTC) #1
borenet
LGTM
6 years, 11 months ago (2014-01-24 17:42:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/143983017/1
6 years, 11 months ago (2014-01-24 18:15:38 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 18:28:38 UTC) #4
Message was sent while issue was closed.
Change committed as 13170

Powered by Google App Engine
This is Rietveld 408576698