src/d8.cc - Issue 143983012: Fix invalid memory access when initializing the command line in d8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 143983012: Fix invalid memory access when initializing the command line in d8 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 1560b09a2b5b77cda7b6592b07be6aa865503f46..76ff4f94318890a4cd3b23b3b42208fec4c3d409 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -1564,13 +1564,14 @@ int Shell::RunMain(Isolate* isolate, int argc, char* argv[]) {

#ifdef V8_SHARED

static void SetStandaloneFlagsViaCommandLine() {

- int fake_argc = 2;

- char **fake_argv = new char*[2];

+ int fake_argc = 3;

+ char **fake_argv = new char*[3];

fake_argv[0] = NULL;

fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg");

fake_argv[2] = strdup("--redirect-code-traces-to=code.asm");

v8::V8::SetFlagsFromCommandLine(&fake_argc, fake_argv, false);

free(fake_argv[1]);

+ free(fake_argv[2]);

delete[] fake_argv;

}

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »