Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/core/svg/SVGElement.cpp

Issue 143983007: Remove PostAttachCallbacks and replace with something more specialized (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // calling rebuildAllElementReferencesForTarget() and 108 // calling rebuildAllElementReferencesForTarget() and
109 // removeAllElementReferencesForTarget() below. 109 // removeAllElementReferencesForTarget() below.
110 clearHasSVGRareData(); 110 clearHasSVGRareData();
111 } 111 }
112 document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this); 112 document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this);
113 document().accessSVGExtensions().removeAllElementReferencesForTarget(this); 113 document().accessSVGExtensions().removeAllElementReferencesForTarget(this);
114 } 114 }
115 115
116 void SVGElement::willRecalcStyle(StyleRecalcChange change) 116 void SVGElement::willRecalcStyle(StyleRecalcChange change)
117 { 117 {
118 // FIXME: This assumes that when shouldNotifyRendererWithIdenticalStyles() i s true 118 if (!hasSVGRareData())
119 // the change came from a SMIL animation, but what if there were non-SMIL ch anges
120 // since then? I think we should remove the shouldNotifyRendererWithIdentica lStyles
121 // check.
122 if (!hasSVGRareData() || shouldNotifyRendererWithIdenticalStyles())
123 return; 119 return;
124 // If the style changes because of a regular property change (not induced by SMIL animations themselves) 120 // If the style changes because of a regular property change (not induced by SMIL animations themselves)
125 // reset the "computed style without SMIL style properties", so the base val ue change gets reflected. 121 // reset the "computed style without SMIL style properties", so the base val ue change gets reflected.
126 if (change > NoChange || needsStyleRecalc()) 122 if (change > NoChange || needsStyleRecalc())
127 svgRareData()->setNeedsOverrideComputedStyleUpdate(); 123 svgRareData()->setNeedsOverrideComputedStyleUpdate();
128 } 124 }
129 125
130 void SVGElement::buildPendingResourcesIfNeeded() 126 void SVGElement::buildPendingResourcesIfNeeded()
131 { 127 {
132 Document& document = this->document(); 128 Document& document = this->document();
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 animatableAttributes.add(SVGNames::zAttr); 1127 animatableAttributes.add(SVGNames::zAttr);
1132 } 1128 }
1133 1129
1134 if (name == classAttr) 1130 if (name == classAttr)
1135 return true; 1131 return true;
1136 1132
1137 return animatableAttributes.contains(name); 1133 return animatableAttributes.contains(name);
1138 } 1134 }
1139 #endif 1135 #endif
1140 } 1136 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698