Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14398005: Remove data reduction proxy from about:flags (Closed)

Created:
7 years, 8 months ago by bengr
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Remove data reduction proxy from about:flags BUG=234739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196817

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 4 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bengr
7 years, 8 months ago (2013-04-25 17:10:42 UTC) #1
Lei Zhang
https://codereview.chromium.org/14398005/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/14398005/diff/1/chrome/browser/about_flags.cc#newcode7 chrome/browser/about_flags.cc:7: #include <string.h> If you added this in the previous ...
7 years, 8 months ago (2013-04-25 21:14:47 UTC) #2
Lei Zhang
otherwise lgtm
7 years, 8 months ago (2013-04-25 21:15:15 UTC) #3
bengr
https://codereview.chromium.org/14398005/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/14398005/diff/1/chrome/browser/about_flags.cc#newcode7 chrome/browser/about_flags.cc:7: #include <string.h> On 2013/04/25 21:14:47, Lei Zhang wrote: > ...
7 years, 8 months ago (2013-04-26 18:11:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/14398005/5001
7 years, 8 months ago (2013-04-26 18:11:56 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 20:16:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 196817

Powered by Google App Engine
This is Rietveld 408576698