SVG: Promote d to a property

third_party/WebKit/Source/core/svg/SVGPath.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SVGPath_h
 #define SVGPath_h
 
+#include "core/css/CSSPathValue.h"
 #include "core/svg/SVGPathByteStream.h"
 #include "core/svg/properties/SVGProperty.h"
 
 namespace blink {
 
 class ExceptionState;
 class Path;
 
 class SVGPath : public SVGPropertyBase {
 public:
     typedef void TearOffType;
 
     static PassRefPtrWillBeRawPtr<SVGPath> create()
     {
         return adoptRefWillBeNoop(new SVGPath());
     }
-    static PassRefPtrWillBeRawPtr<SVGPath> create(PassOwnPtr<SVGPathByteStream> pathByteStream)
+    static PassRefPtrWillBeRawPtr<SVGPath> create(PassRefPtrWillBeRawPtr<CSSPathValue> d)

[fs, 2015/12/11 13:01:58]

Nit: I think we should refrain from using "d" in the context of this object
(SVGPath). maybe 'pathValue' instead?

[Eric Willigers, 2015/12/14 05:36:46]

Done.

     {
-        return adoptRefWillBeNoop(new SVGPath(pathByteStream));
+        return adoptRefWillBeNoop(new SVGPath(d));
     }
 
     ~SVGPath() override;
 
-    const Path& path() const;
-
-    const SVGPathByteStream& byteStream() const;
+    const SVGPathByteStream& byteStream() const { return m_pathValue->byteStream(); }
+    CSSPathValue* pathValue() const { return m_pathValue.get(); }
 
     // SVGPropertyBase:
     PassRefPtrWillBeRawPtr<SVGPath> clone() const;
     PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
     String valueAsString() const override;
     void setValueAsString(const String&, ExceptionState&);
 
     void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
     void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> fromValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;
     float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement*) override;
 
     static AnimatedPropertyType classType() { return AnimatedPath; }
 
 private:
     SVGPath();
-    explicit SVGPath(PassOwnPtr<SVGPathByteStream>);
+    explicit SVGPath(PassRefPtrWillBeRawPtr<CSSPathValue> d);

[fs, 2015/12/11 13:01:58]

Nit: Can drop 'd' here (it doesn't really add anything useful IMHO)

[Eric Willigers, 2015/12/14 05:36:46]

Done.

 
-    SVGPathByteStream& ensureByteStream();
-    void byteStreamChanged();
-    void setValueAsByteStream(PassOwnPtr<SVGPathByteStream>);
-
-    OwnPtr<SVGPathByteStream> m_byteStream;
-    mutable OwnPtr<Path> m_cachedPath;
+    RefPtrWillBePersistent<CSSPathValue> m_pathValue;

[fs, 2015/12/11 13:01:58]

You should make this a RefPtrWillBeMember<...> instead and
DECLARE_TRACE/DEFINE_TRACE (SVGPropertyBase inherits
RefCountedWillBeGarbageCollectedFinalized)

[Eric Willigers, 2015/12/14 05:36:46]

Done.

 };
 
 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGPath);
 
 } // namespace blink
 
 #endif