chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc - Issue 143973006: New Sync datatype for Synced Notifications App Info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

Issue 143973006: New Sync datatype for Synced Notifications App Info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/profile_sync_components_factory_impl.cc ('K') | « chrome/browser/sync/profile_sync_components_factory_impl.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | sync/internal_api/public/base/model_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

index d968a69a6515dabce3d36866cd65962b25789153..24ae94bfbe9d57227d52fa6537169c2b1ba989dd 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

@@ -58,6 +58,7 @@ class ProfileSyncComponentsFactoryImplTest : public testing::Test {

datatypes.push_back(syncer::FAVICON_TRACKING);

datatypes.push_back(syncer::FAVICON_IMAGES);

datatypes.push_back(syncer::SYNCED_NOTIFICATIONS);

+ datatypes.push_back(syncer::SYNCED_NOTIFICATION_APP_INFO);

Nicolas Zea 2014/01/22 00:43:39 Are the tests going to pass with this? You'r not a

Pete Williamson 2014/01/22 19:51:10 Good point, I removed this line, and the tests pas

datatypes.push_back(syncer::MANAGED_USERS);

// TODO(bauerb): Enable once the Sync server has been updated to know about

// this data type.