Issue 1439723002: Exclude 'doc' folders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1439723002: Exclude 'doc' folders. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Exclude 'doc' folders. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/02fe5bcd5af7b25e0ff2fd73c751865b323baf85

Patch Set 2 : Exclude only top-level 'doc' folders. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -10 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View	1	5 chunks	+26 lines, -10 lines	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View	1	2 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

https://codereview.chromium.org/1439723002/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1439723002/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode697 pkg/analysis_server/lib/src/context_manager.dart:697: folder.shortName == DOC_DIR_NAME) { Do we really want to ...

5 years, 1 month ago (2015-11-11 19:27:16 UTC) #2

scheglov

No, we need to exclude only top-level "doc" folders. PTAL

5 years, 1 month ago (2015-11-11 21:03:35 UTC) #3

scheglov

5 years, 1 month ago (2015-11-11 21:10:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
02fe5bcd5af7b25e0ff2fd73c751865b323baf85 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1439723002: Exclude 'doc' folders. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Exclude only top-level 'doc' folders. #

Messages