Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: src/runtime/runtime-proxy.cc

Issue 1439693002: [runtime] Support Proxy setPrototypeOf trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2015-11-09_new_Proxy_1417063011
Patch Set: reverting error change Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-proxy.cc
diff --git a/src/runtime/runtime-proxy.cc b/src/runtime/runtime-proxy.cc
index 5a12f1050aff985065973386035f552dc1dee377..d1b3238ccbd0b7e1cf1798f590352368c8e2a2c7 100644
--- a/src/runtime/runtime-proxy.cc
+++ b/src/runtime/runtime-proxy.cc
@@ -31,9 +31,8 @@ RUNTIME_FUNCTION(Runtime_CreateJSProxy) {
isolate, NewTypeError(MessageTemplate::kProxyHandlerNonObject));
}
if (handler->IsJSProxy() && !JSProxy::cast(*handler)->has_handler()) {
- // TODO(cbruni): Use better error message.
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kProxyHandlerNonObject));
+ THROW_NEW_ERROR_RETURN_FAILURE(isolate,
+ NewTypeError(MessageTemplate::kProtoNotSet));
}
instance->set_target(*target);
instance->set_handler(*handler);

Powered by Google App Engine
This is Rietveld 408576698