src/objects.h - Issue 1439693002: [runtime] Support Proxy setPrototypeOf trap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1439693002: [runtime] Support Proxy setPrototypeOf trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2015-11-09_new_Proxy_1417063011

Patch Set: reverting error change Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 38f5b7d503d8d2669058e4c580d6203f0f36500d..0adf6eea2906c3136a72ad75e94033c3a88fa3f3 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1030,7 +1030,7 @@ class Object {

#define RETURN_FAILURE(isolate, should_throw, call) \

do { \

- if ((should_throw) == DONT_THROW) { \

+ if ((should_throw) == Object::DONT_THROW) { \

return Just(false); \

} else { \

isolate->Throw(*isolate->factory()->call); \

@@ -9578,7 +9578,11 @@ class JSProxy: public JSReceiver {

DECLARE_CAST(JSProxy)

- static MaybeHandle<Object> GetPrototype(Handle<JSProxy> receiver);

+ // Proxy Traps:

+ static MaybeHandle<Object> GetPrototype(Handle<JSProxy> proxy);

+ static Maybe<bool> SetPrototype(Handle<JSProxy> proxy, Handle<Object> value,

+ bool from_javascript,

+ ShouldThrow should_throw);

neis 2015/11/16 19:09:54 Shouldn't they be marked as MUST_USE_RESULT?

MUST_USE_RESULT static MaybeHandle<Object> GetPropertyWithHandler(

Handle<JSProxy> proxy,

« src/messages.h ('K') | « src/messages.h ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')