[runtime] Support Proxy setPrototypeOf trap

[runtime] [proxy] adding [[SetPrototypeOf]] trap.

LOG=N
BUG=v8:1543

[Camillo Bruni, 2015-11-12 09:27:04]

work in progress

[Camillo Bruni, 2015-11-13 16:07:29]

Description was changed from

==========
Support Proxy SetPrototype

BUG=
==========

to

==========
[runtime] Support Proxy setPrototypeOf trap

LOG=N
BUG=v8:1543
==========

[Camillo Bruni, 2015-11-13 16:38:26]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 16:38:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439693002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439693002/120001

[Camillo Bruni, 2015-11-13 16:44:22]

cbruni@chromium.org changed reviewers:
+ verwaest@chromium.org

[Camillo Bruni, 2015-11-13 16:44:22]

PTAL

[commit-bot: I haz the power, 2015-11-13 17:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 17:10:38]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2015-11-13 17:28:21]

https://codereview.chromium.org/1439693002/diff/120001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1439693002/diff/120001/src/objects.cc#newcode631
src/objects.cc:631: // TODO(cbruni,neis): Propagage should_throw here.
Propagate

https://codereview.chromium.org/1439693002/diff/120001/src/objects.cc#newcode639
src/objects.cc:639: // TODO(bmeurer): Better error message here?
The spec says you actually have to throw a TypeError here. This does not return
false, so ShouldThrow shouldn't be passed in.

I'll wait with reviewing the CL until this is fixed (as discussed offline).

[Camillo Bruni, 2015-11-16 13:32:08]

PTAL again, removed the wrong should_throw code.

https://codereview.chromium.org/1439693002/diff/220001/src/runtime/runtime-ob...
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/1439693002/diff/220001/src/runtime/runtime-ob...
src/runtime/runtime-object.cc:189: if (!status.FromJust()) {
We should probably throw the error already in JSProxy::SetPrototype in case the
trap return false, thus allowing for a more specific error message.

[neis, 2015-11-16 19:09:52]

neis@chromium.org changed reviewers:
+ neis@chromium.org

[neis, 2015-11-16 19:09:54]

https://codereview.chromium.org/1439693002/diff/220001/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/1439693002/diff/220001/src/messages.h#newcode159
src/messages.h:159: T(ObjectSetPrototypeFailed, "Could not set '%' as Protoype
on '%'")          \
s/Protoype/prototype/
But why do we need both this one and ProtoNotSet below?

https://codereview.chromium.org/1439693002/diff/220001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1439693002/diff/220001/src/objects.cc#newcode...
src/objects.cc:14023: if (!object->IsJSReceiver()) return Just(false);
What's the motivation for this?

https://codereview.chromium.org/1439693002/diff/220001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1439693002/diff/220001/src/objects.h#newcode9585
src/objects.h:9585: ShouldThrow should_throw);
Shouldn't they be marked as MUST_USE_RESULT?

https://codereview.chromium.org/1439693002/diff/220001/test/mjsunit/harmony/p...
File test/mjsunit/harmony/proxy/proxy-setPrototypeOf.js (right):

https://codereview.chromium.org/1439693002/diff/220001/test/mjsunit/harmony/p...
test/mjsunit/harmony/proxy/proxy-setPrototypeOf.js:59: assertSame(prototype,
Object.getPrototypeOf(target));
For consistency, can you name this file proxies-set-prototype-of.js and move it
into harmony/ ?

[Camillo Bruni, 2015-11-30 13:07:22]

Description was changed from

==========
[runtime] Support Proxy setPrototypeOf trap

LOG=N
BUG=v8:1543
==========

to

==========
[runtime] [proxy] adding [[SetPrototypeOf]] trap.

LOG=N
BUG=v8:1543
==========