Issue 143963006: [MIPS] Set make_global_settings correctly for MIPS-Linux

Issue 143963006: [MIPS] Set make_global_settings correctly for MIPS-Linux (Closed)

Created:
6 years, 11 months ago by petarj

Modified:
6 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

[MIPS] Set make_global_settings correctly for MIPS-Linux Fix build regression for MIPS Linux that came with r245563. BUG= build regression for MIPS Linux TEST= build Chromium for MIPS Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246300

Patch Set 1 #

Patch Set 2 : Add empty sysroot for linux for non-mipsel #

Total comments: 2

Patch Set 3 : Style change. #

Created: 6 years, 11 months ago

		Unified diffs	Side-by-side diffs	Stats (+16 lines, -1 line)
	M	build/config/sysroot.gni	View	1 chunk	+6 lines, -0 lines	0 comments
	M	build/toolchain/linux/BUILD.gn	View	2 chunks	+10 lines, -1 line	0 comments

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/143963006/diff/160001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/143963006/diff/160001/build/config/sysroot.gni#newcode38 build/config/sysroot.gni:38: sysroot = rebase_path( I think this fits on ...

6 years, 11 months ago (2014-01-22 01:04:30 UTC) #2

petarj

https://codereview.chromium.org/143963006/diff/160001/build/config/sysroot.gni File build/config/sysroot.gni (right): https://codereview.chromium.org/143963006/diff/160001/build/config/sysroot.gni#newcode38 build/config/sysroot.gni:38: sysroot = rebase_path( On 2014/01/22 01:04:30, brettw wrote: > ...

6 years, 11 months ago (2014-01-22 01:22:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/143963006/190004

6 years, 11 months ago (2014-01-22 01:25:08 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) app_list_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, ...

6 years, 11 months ago (2014-01-22 02:56:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/143963006/190004

6 years, 11 months ago (2014-01-22 03:09:02 UTC) #6

Message was sent while issue was closed.

Change committed as 246300

Expand Messages | Collapse Messages