[turbofan] Better and more sane support for tail calls

src/compiler/instruction-selector.h

Index: src/compiler/instruction-selector.h
diff --git a/src/compiler/instruction-selector.h b/src/compiler/instruction-selector.h
index 68a45157f991900ef40c362fa14252e5c28be8a5..afc016740c49362d1aa45fa963ef3bb2f72ef54e 100644
--- a/src/compiler/instruction-selector.h
+++ b/src/compiler/instruction-selector.h
@@ -164,14 +164,19 @@ class InstructionSelector final {
   // operand {op}.
   void MarkAsRepresentation(MachineType rep, const InstructionOperand& op);
 
+  enum CallBufferFlags {
+    CALL_CODE_IMMEDIATE = 1,
+    CALL_ADDRESS_IMMEDIATE = 2,
+    CALL_TAIL = 4
+  };

[Jarin, 2015/11/13 10:42:49]

Please use "typedef base::Flags<CallBufferFlags> CallBufferInitFlags;" and then
refer to CallBufferInitFlags. That way you can avoid the ugly casts.

Also, the convention for enums is hungarian/camel (kCallCodeImmediate).

[danno, 2015/11/13 11:54:11]

Done.

+
   // Initialize the call buffer with the InstructionOperands, nodes, etc,
   // corresponding
   // to the inputs and outputs of the call.
   // {call_code_immediate} to generate immediate operands to calls of code.
   // {call_address_immediate} to generate immediate operands to address calls.
   void InitializeCallBuffer(Node* call, CallBuffer* buffer,
-                            bool call_code_immediate,
-                            bool call_address_immediate);
+                            CallBufferFlags flags, int stack_param_delta = 0);
   bool IsTailCallAddressImmediate();
 
   FrameStateDescriptor* GetFrameStateDescriptor(Node* node);