Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1439603002: Fix a bug in type inference for locals in switch statements. (Closed)

Created:
5 years, 1 month ago by herhut
Modified:
5 years ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bug in type inference for locals in switch statements. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/1fdcb882d58c156fc8f720cc65acb46f15760f43

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -13 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +21 lines, -13 lines 2 comments Download
A tests/compiler/dart2js/type_inference_switch_test.dart View 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
herhut
5 years, 1 month ago (2015-11-11 11:51:35 UTC) #3
Kevin Millikin (Google)
lgtm https://codereview.chromium.org/1439603002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right): https://codereview.chromium.org/1439603002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart#newcode614 pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:614: bool allBranchesAbort = true; An extra space has ...
5 years, 1 month ago (2015-11-11 12:14:52 UTC) #4
herhut
Committed patchset #1 (id:1) manually as 1fdcb882d58c156fc8f720cc65acb46f15760f43 (presubmit successful).
5 years, 1 month ago (2015-11-11 15:03:24 UTC) #5
herhut
5 years ago (2015-12-10 10:09:11 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1439603002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://codereview.chromium.org/1439603002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:614: bool allBranchesAbort =
true;
On 2015/11/11 12:14:52, Kevin Millikin (Google) wrote:
> An extra space has crept in.

Done.

Powered by Google App Engine
This is Rietveld 408576698