Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 14396004: Shared build fix (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/d8.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Please take a look
7 years, 7 months ago (2013-04-29 12:42:34 UTC) #1
rossberg
lgtm
7 years, 7 months ago (2013-04-29 14:12:13 UTC) #2
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-04-29 14:13:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698