Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: media/base/video_capture_types.h

Issue 1439533004: Remove dead code paths around PIXEL_STORAGE_TEXTURE in capture pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mcasas's second round comments REBASE Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/video_capture_message_filter_unittest.cc ('k') | media/base/video_capture_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_capture_types.h
diff --git a/media/base/video_capture_types.h b/media/base/video_capture_types.h
index d6ad5e3a736812f2d8f6ad8d0a275566402bcdaa..fa631a091e94496cb7494f163270a57d0a814e71 100644
--- a/media/base/video_capture_types.h
+++ b/media/base/video_capture_types.h
@@ -24,7 +24,6 @@ typedef int VideoCaptureSessionId;
// TODO(mcasas): http://crbug.com/504160 Consider making this an enum class.
enum VideoPixelStorage {
PIXEL_STORAGE_CPU,
- PIXEL_STORAGE_TEXTURE,
PIXEL_STORAGE_GPUMEMORYBUFFER,
PIXEL_STORAGE_MAX = PIXEL_STORAGE_GPUMEMORYBUFFER,
};
@@ -126,6 +125,10 @@ typedef std::vector<VideoCaptureFormat> VideoCaptureFormats;
struct MEDIA_EXPORT VideoCaptureParams {
VideoCaptureParams();
+ // Returns true if requested_format.IsValid() and all other values are within
+ // their expected ranges.
+ bool IsValid() const;
+
bool operator==(const VideoCaptureParams& other) const {
return requested_format == other.requested_format &&
resolution_change_policy == other.resolution_change_policy &&
« no previous file with comments | « content/renderer/media/video_capture_message_filter_unittest.cc ('k') | media/base/video_capture_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698