content/browser/renderer_host/media/video_capture_host.cc - Issue 1439533004: Remove dead code paths around PIXEL_STORAGE_TEXTURE in capture pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_host.cc

Issue 1439533004: Remove dead code paths around PIXEL_STORAGE_TEXTURE in capture pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mcasas's second round comments REBASE Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h ('k') | content/common/media/video_capture_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_host.cc

diff --git a/content/browser/renderer_host/media/video_capture_host.cc b/content/browser/renderer_host/media/video_capture_host.cc

index f07dfbc63fc57893cefeeb6dae96d02f50b41c01..ed3fea6485894c4f1aa8067423b740dfd482df9f 100644

--- a/content/browser/renderer_host/media/video_capture_host.cc

+++ b/content/browser/renderer_host/media/video_capture_host.cc

@@ -105,11 +105,6 @@ void VideoCaptureHost::OnBufferReady(

params.storage_type = video_frame->storage_type();

params.coded_size = video_frame->coded_size();

params.visible_rect = video_frame->visible_rect();

- if (video_frame->HasTextures()) {

- DCHECK_EQ(1u, media::VideoFrame::NumPlanes(video_frame->format()))

- << "Only single planar textures are supported";

- params.mailbox_holder = video_frame->mailbox_holder(0);

- }

Send(new VideoCaptureMsg_BufferReady(params));

}