Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 1439533003: Readd "immediate" mode (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Readd "immediate" mode This isn't an exact replacement. The accumulated batches are now flushed at drawContext-entry-point granularity (via the AutoCheckFlush objects) rather than per batch. TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/caef3450488f98aa0bc429c4e2d8e29d6a7fece4

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +5 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrCaps.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
5 years, 1 month ago (2015-11-11 20:22:50 UTC) #5
joshualitt
On 2015/11/11 20:22:50, robertphillips wrote: lgtm
5 years, 1 month ago (2015-11-11 21:02:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439533003/20001
5 years, 1 month ago (2015-11-11 21:03:01 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 21:15:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439533003/20001
5 years, 1 month ago (2015-11-11 21:17:32 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 21:18:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/caef3450488f98aa0bc429c4e2d8e29d6a7fece4

Powered by Google App Engine
This is Rietveld 408576698