Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1439533002: [turbofan] Add support to lower Function.prototype.call. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support to lower Function.prototype.call. Support lowering of Function.prototype.call in the JSBuiltinReducer, which is actually straightforward because of the way we represent JS calls in TurboFan. Currently we cannot inline the actual target yet, since inlining still runs before typed lowering, but that will be possible as well soon(ish). R=jarin@chromium.org Committed: https://crrev.com/f5e6dcb62b8ca0478f2c718794023afef055eb99 Cr-Commit-Position: refs/heads/master@{#31938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M src/compiler/js-builtin-reducer.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 4 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-11 06:47:13 UTC) #1
Benedikt Meurer
Hey Jaro, Sometimes TurboFan is just awesome, and simple things are actually very simple :-) ...
5 years, 1 month ago (2015-11-11 06:47:51 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-11 06:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439533002/1
5 years, 1 month ago (2015-11-11 07:25:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 07:26:26 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 07:26:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5e6dcb62b8ca0478f2c718794023afef055eb99
Cr-Commit-Position: refs/heads/master@{#31938}

Powered by Google App Engine
This is Rietveld 408576698