Listen for input and change event to change color opacity value

Listen for input and change event to change color opacity value

The issue does arise due to change for slide change event changes in https://codereview.chromium.org/125973004/.

The issue is due to Spectrum.js is listening for change event and none gets fired after the above commit. As per spec (http://www.w3.org/TR/html5/forms.html#common-event-behaviors) for type range, input event should be firedi while dragging, while change event is fired when dragging is stopped. As values needs to be updated during drag, input event should also be listened.

Spectrum.js is updated to listen for both input and change event to resolve above issue.

R=tkent
BUG=337801
TEST=NONE

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166026

[Habib Virji, 2014-01-24 18:10:37]

Listen for input and change event to change color opacity value    
  
The issue is due to Spectrum.js is listening for change event and none gets
fired after the above commit. As per spec
(http://www.w3.org/TR/html5/forms.html#common-event-behaviors) for type range,
input event should be fired while dragging, while change event is fired when
dragging is stopped. As values needs to be updated during drag, input event
should also be listened.

Spectrum.js is updated to listen for both input and change event to resolve
above issue.

[tkent, 2014-01-27 01:20:41]

> TEST=NONE

Why does this CL have no tests?

https://codereview.chromium.org/143953014/diff/1/Source/devtools/front_end/Sp...
File Source/devtools/front_end/Spectrum.js (right):

https://codereview.chromium.org/143953014/diff/1/Source/devtools/front_end/Sp...
Source/devtools/front_end/Spectrum.js:60:
this._alphaElement.addEventListener("change", alphaDrag.bind(this), false);
Do we need to listen 'change' event?

[Habib Virji, 2014-01-27 18:51:32]

There are no test for Spectrum.js. Please let me know if to add one for this
change.

Change event has to be listened still as when mouseUp is triggered it will
trigger change event.

[tkent, 2014-01-28 01:28:20]

On 2014/01/27 18:51:32, habib.virji wrote:
> There are no test for Spectrum.js. Please let me know if to add one for this
> change.

I'm not familiar with testing for inspector.  pfeldman, do you have any advice?

> Change event has to be listened still as when mouseUp is triggered it will
> trigger change event.

Whenever 'change' event is dispatched, 'input' event should be dispatched as
well.  I checked the behavior of input[type=range], and it seems we have a bug.

[tkent, 2014-01-28 01:28:42]

+pfeldman

[Habib Virji, 2014-01-28 08:14:13]

On 2014/01/28 01:28:20, tkent wrote:
> On 2014/01/27 18:51:32, habib.virji wrote:
> > There are no test for Spectrum.js. Please let me know if to add one for this
> > change.
> 
> I'm not familiar with testing for inspector.  pfeldman, do you have any
advice?
> 
> > Change event has to be listened still as when mouseUp is triggered it will
> > trigger change event.
> 
> Whenever 'change' event is dispatched, 'input' event should be dispatched as
> well.  I checked the behavior of input[type=range], and it seems we have a
bug.

I probably have an idea why this happens. Should I have a look at why range dos
not trigger both.

[Habib Virji, 2014-01-28 17:55:33]

On 2014/01/28 01:28:20, tkent wrote:
> On 2014/01/27 18:51:32, habib.virji wrote:
> > There are no test for Spectrum.js. Please let me know if to add one for this
> > change.
> 
> I'm not familiar with testing for inspector.  pfeldman, do you have any
advice?
> 
> > Change event has to be listened still as when mouseUp is triggered it will
> > trigger change event.
> 
> Whenever 'change' event is dispatched, 'input' event should be dispatched as
> well.  I checked the behavior of input[type=range], and it seems we have a
bug.

Uploaded CL 148763005 with the fix for range to send both input and change
event.

[Habib Virji, 2014-01-29 09:35:51]

Reverted back to old patch as CL 148763005, was not valid.

[Habib Virji, 2014-01-29 13:41:33]

@pfeldman, can you please review the change

[pfeldman, 2014-01-29 13:44:51]

lgtm

[Habib Virji, 2014-01-29 14:16:08]

On 2014/01/29 13:44:51, pfeldman wrote:
> lgtm

Can you please commit and initiate try bot, as I cannot do it.

[commit-bot: I haz the power, 2014-01-29 14:22:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/143953014/70001

[commit-bot: I haz the power, 2014-01-29 16:13:02]

Change committed as 166026

[commit-bot: I haz the power, 2014-01-29 16:15:32]

CQ bit was unchecked on CL. Ignoring.