Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1439493003: Documentation: clean up (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Documentation: clean up - /user/quick/desktop to bring together all common information for using Skia on desktop OSes. Remove duplication. - Replace all instances of call ing gyp_skia directly with calling `python bin/sync-and-gyp`. This is more correct on Windows - Remove outdated linux prerequisite packages - Formatting, formatting, formatting. - Note command-line syntax differences in Windows - SampleApp.app is no longer a bundle on MacOS NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1439493003 Committed: https://skia.googlesource.com/skia/+/e0c64c5846b7c2a2d078bbaf954e15cee56fdbe6

Patch Set 1 #

Patch Set 2 : 2015-11-11 (Wednesday) 12:08:10 EST #

Patch Set 3 : 2015-11-11 (Wednesday) 12:09:52 EST #

Patch Set 4 : 2015-11-11 (Wednesday) 12:52:08 EST #

Patch Set 5 : 2015-11-11 (Wednesday) 14:13:18 EST #

Patch Set 6 : 2015-11-11 (Wednesday) 14:17:20 EST #

Patch Set 7 : 2015-11-12 (Thursday) 13:09:23 EST #

Patch Set 8 : 2015-11-12 (Thursday) 15:18:10 EST #

Total comments: 16

Patch Set 9 : 2015-11-13 (Friday) 07:21:08 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -308 lines) Patch
M site/dev/contrib/submit.md View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M site/dev/testing/testing.md View 1 2 3 4 5 6 7 4 chunks +8 lines, -8 lines 0 comments Download
M site/dev/testing/tests.md View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M site/dev/tools/debugger.md View 1 2 3 4 5 6 7 1 chunk +4 lines, -6 lines 0 comments Download
M site/user/download.md View 1 2 3 4 5 6 7 2 chunks +0 lines, -14 lines 0 comments Download
A site/user/quick/METADATA View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M site/user/quick/android.md View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -9 lines 0 comments Download
A site/user/quick/desktop.md View 1 2 3 4 5 6 7 8 1 chunk +135 lines, -0 lines 0 comments Download
M site/user/quick/index.md View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M site/user/quick/ios.md View 1 2 3 4 5 6 7 4 chunks +16 lines, -27 lines 0 comments Download
M site/user/quick/linux.md View 1 2 3 4 5 6 7 2 chunks +43 lines, -127 lines 0 comments Download
M site/user/quick/macos.md View 1 2 3 4 5 6 7 5 chunks +31 lines, -41 lines 0 comments Download
M site/user/quick/windows.md View 1 2 3 4 5 6 7 8 1 chunk +101 lines, -66 lines 0 comments Download
M site/user/tips.md View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hal.canary
PTAL
5 years, 1 month ago (2015-11-12 20:20:27 UTC) #3
hcm
Nice! A few minor things.. https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md File site/user/download.md (left): https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md#oldcode27 site/user/download.md:27: Curious why we are ...
5 years, 1 month ago (2015-11-13 05:03:45 UTC) #4
hal.canary
https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md File site/user/download.md (left): https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md#oldcode27 site/user/download.md:27: On 2015/11/13 at 05:03:45, hcm wrote: > Curious why ...
5 years, 1 month ago (2015-11-13 12:21:46 UTC) #5
hcm
On 2015/11/13 12:21:46, Hal Canary wrote: > https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md > File site/user/download.md (left): > > https://codereview.chromium.org/1439493003/diff/140001/site/user/download.md#oldcode27 ...
5 years, 1 month ago (2015-11-13 12:28:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439493003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439493003/160001
5 years, 1 month ago (2015-11-13 12:28:48 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 12:30:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/e0c64c5846b7c2a2d078bbaf954e15cee56fdbe6

Powered by Google App Engine
This is Rietveld 408576698