Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: runtime/vm/isolate.h

Issue 1439483003: - Add an OSThread structure which is the generic TLS structure for all C++ (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 5f721a3cf5de9fc0655976ed3c53d083facda334..979888dc41021736549dd5ffa3ba01590aed9e67 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -254,8 +254,6 @@ class Isolate : public BaseIsolate {
// The true stack limit for this isolate.
uword saved_stack_limit() const { return saved_stack_limit_; }
- uword stack_base() const { return stack_base_; }
-
// Stack overflow flags
enum {
kOsrRequest = 0x1, // Current stack overflow caused by OSR request.
@@ -274,13 +272,6 @@ class Isolate : public BaseIsolate {
// stack overflow is called.
uword GetAndClearStackOverflowFlags();
- // Retrieve the stack address bounds for profiler.
- bool GetProfilerStackBounds(uword* lower, uword* upper) const;
-
- static uword GetSpecifiedStackSize();
-
- static const intptr_t kStackSizeBuffer = (4 * KB * kWordSize);
-
// Interrupt bits.
enum {
kVMInterrupt = 0x1, // Internal VM checks: safepoints, store buffers, etc.
@@ -771,7 +762,6 @@ class Isolate : public BaseIsolate {
Simulator* simulator_;
Mutex* mutex_; // protects stack_limit_, saved_stack_limit_, compiler stats.
uword saved_stack_limit_;
- uword stack_base_;
uword stack_overflow_flags_;
int32_t stack_overflow_count_;
MessageHandler* message_handler_;
@@ -908,7 +898,7 @@ class StartIsolateScope {
if (saved_isolate_ != new_isolate_) {
ASSERT(Isolate::Current() == NULL);
// Ensure this is not a nested 'isolate enter' with prior state.
- ASSERT(new_isolate_->stack_base() == 0);
+ ASSERT(new_isolate_->saved_stack_limit() == 0);
Thread::EnterIsolate(new_isolate_);
}
}
@@ -922,7 +912,7 @@ class StartIsolateScope {
if (saved_isolate_ != new_isolate_) {
ASSERT(saved_isolate_ == NULL);
// ASSERT that we have bottomed out of all Dart invocations.
- ASSERT(new_isolate_->stack_base() == 0);
+ ASSERT(new_isolate_->saved_stack_limit() == 0);
Thread::ExitIsolate();
}
}

Powered by Google App Engine
This is Rietveld 408576698