runtime/vm/debugger_api_impl_test.cc - Issue 1439483003: - Add an OSThread structure which is the generic TLS structure for all C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 1439483003: - Add an OSThread structure which is the generic TLS structure for all C++ (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_api_impl_test.cc

diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc

index 80b287941e5b1dd5731da30319e57698ceef5144..0420b2e06d1763fad305313081c2ac5ae72e84e0 100644

--- a/runtime/vm/debugger_api_impl_test.cc

+++ b/runtime/vm/debugger_api_impl_test.cc

@@ -1510,7 +1510,7 @@ TEST_CASE(Debug_InterruptIsolate) {

sync = new Monitor();

EXPECT(interrupt_isolate_id == ILLEGAL_ISOLATE_ID);

Dart_SetPausedEventHandler(InterruptIsolateHandler);

- int result = OSThread::Start(InterruptIsolateRun, 0);

+ int result = OSThread::Start("DebugInterruptIsolate", InterruptIsolateRun, 0);

EXPECT_EQ(0, result);

// Wait for the test isolate to be created.

« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/isolate.h » ('j') | runtime/vm/os_thread.cc » ('J')