- Add an OSThread structure which is the generic TLS structure for all C++

runtime/vm/thread_pool.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread_pool.h"
 
 #include "vm/flags.h"
 #include "vm/lockers.h"
 
 namespace dart {
@@ skipping 315 matching lines @@
 
 
 void ThreadPool::Worker::StartThread() {
 #if defined(DEBUG)
   // Must call SetTask before StartThread.
   { // NOLINT
     MonitorLocker ml(&monitor_);
     ASSERT(task_ != NULL);
   }
 #endif
-  int result = OSThread::Start(&Worker::Main, reinterpret_cast<uword>(this));
+  int result = OSThread::Start("Dart ThreadPool Worker",
+                               &Worker::Main,
+                               reinterpret_cast<uword>(this));
   if (result != 0) {
     FATAL1("Could not start worker thread: result = %d.", result);
   }
 }
 
 
 void ThreadPool::Worker::SetTask(Task* task) {
   MonitorLocker ml(&monitor_);
   ASSERT(task_ == NULL);
   task_ = task;
@@ skipping 63 matching lines @@
 
 void ThreadPool::Worker::Shutdown() {
   MonitorLocker ml(&monitor_);
   done_ = true;
   ml.Notify();
 }
 
 
 // static
 void ThreadPool::Worker::Main(uword args) {
-  Thread::EnsureInit();
-  Thread* thread = Thread::Current();
-  thread->set_name("Dart ThreadPool Worker");
   Worker* worker = reinterpret_cast<Worker*>(args);
   ThreadId id = OSThread::GetCurrentThreadId();
   ThreadJoinId join_id = OSThread::GetCurrentThreadJoinId();

[zra, 2015/11/16 20:12:28]

In the future on Windows we might want to ensure that
OSThread::GetCurrentThreadJoinId() is called only once, so here we'd want to do
something like 'OSThread::Current()->join_id();' to get the value cached from
when the thread started up.

[siva, 2015/11/17 20:52:25]

Changed this to os_thread->Id() and os_thread->JoinId()

   ThreadPool* pool;
 
   {
     MonitorLocker ml(&worker->monitor_);
     ASSERT(worker->task_);
     worker->id_ = id;
     pool = worker->pool_;
   }
 
   bool released = worker->Loop();
@@ skipping 33 matching lines @@
     // is not due to a ThreadPool Shutdown. Thus, we simply delete the worker.
     // The worker's id is added to the thread pool's join list by
     // ReleaseIdleWorker, so in the case that the thread pool begins shutting
     // down immediately after returning from worker->Loop() above, we still
     // wait for the thread to exit by joining on it in Shutdown().
     delete worker;
   }
 }
 
 }  // namespace dart