- Add an OSThread structure which is the generic TLS structure for all C++

runtime/vm/thread_interrupter_linux.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_LINUX)
 
 #include <errno.h>  // NOLINT
 
 #include "vm/flags.h"
 #include "vm/os.h"
 #include "vm/profiler.h"
 #include "vm/signal_handler.h"
 #include "vm/thread_interrupter.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, thread_interrupter);
 DECLARE_FLAG(bool, trace_thread_interrupter);
 
 class ThreadInterrupterLinux : public AllStatic {
  public:
   static void ThreadInterruptSignalHandler(int signal, siginfo_t* info,
                                            void* context_) {
     if (signal != SIGPROF) {
       return;
     }
     Thread* thread = Thread::Current();

[Cutch, 2015/11/14 00:31:56]

I think this should be OSThread and not Thread.

[siva, 2015/11/14 01:38:26]

Currently SampleThread in the profiler only seems to sample threads that are
associated with an isolate and that is why I retained the signature of
Profiler::SampleThread(Thread* thr, const InterruptedThreadState& state).

We could at a later stage extend this for all threads.

     if (thread == NULL) {
       return;
     }
     // Extract thread state.
     ucontext_t* context = reinterpret_cast<ucontext_t*>(context_);
     mcontext_t mcontext = context->uc_mcontext;
     InterruptedThreadState its;
     its.pc = SignalHandler::GetProgramCounter(mcontext);
     its.fp = SignalHandler::GetFramePointer(mcontext);
     its.csp = SignalHandler::GetCStackPointer(mcontext);
     its.dsp = SignalHandler::GetDartStackPointer(mcontext);
     its.lr = SignalHandler::GetLinkRegister(mcontext);
     Profiler::SampleThread(thread, its);
   }
 };
 
 
-void ThreadInterrupter::InterruptThread(Thread* thread) {
+void ThreadInterrupter::InterruptThread(OSThread* thread) {

[Cutch, 2015/11/14 00:31:56]

This change needs to be made in os_thread_interrupter_*.cc

[siva, 2015/11/14 01:38:26]

Good catch.

Done.

   if (FLAG_trace_thread_interrupter) {
     OS::Print("ThreadInterrupter interrupting %p\n",
               reinterpret_cast<void*>(thread->id()));
   }
   int result = pthread_kill(thread->id(), SIGPROF);
   ASSERT((result == 0) || (result == ESRCH));
 }
 
 
 void ThreadInterrupter::InstallSignalHandler() {
   SignalHandler::Install(ThreadInterrupterLinux::ThreadInterruptSignalHandler);
 }
 
 
 void ThreadInterrupter::RemoveSignalHandler() {
   SignalHandler::Remove();
 }
 
 
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_LINUX)