Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: tests/ClampRangeTest.cpp

Issue 1439483002: Fix code that left shifts a negative value. This has undefined behavior. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add comment about unsigned cast. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkFixed.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ClampRangeTest.cpp
diff --git a/tests/ClampRangeTest.cpp b/tests/ClampRangeTest.cpp
index ccce8c5bf3bc0286793b422275dd29207e7d2909..9027e9b31146323afd58e97f7b84529214b74c9c 100644
--- a/tests/ClampRangeTest.cpp
+++ b/tests/ClampRangeTest.cpp
@@ -82,8 +82,7 @@ DEF_TEST(ClampRange, reporter) {
test_range(ff(1), ff(16384), 100);
test_range(ff(-1), ff(-16384), 100);
test_range(ff(1)/2, ff(16384), 100);
- // TODO(reed): skia:2481, fix whatever bug this is, then uncomment
- //test_range(ff(1)/2, ff(-16384), 100);
+ test_range(ff(1)/2, ff(-16384), 100);
SkRandom rand;
« no previous file with comments | « include/core/SkFixed.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698