Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1439473003: [turbofan] Move simplified alloc, load and store lowering to change lowering. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move simplified alloc, load and store lowering to change lowering. This is necessary to allow more optimizations to take place between the representation inference and change lowering. Perhaps we want to rename SimplifiedLowering -> RepresentationInference and ChangeLowering -> SimplifiedLowering. Committed: https://crrev.com/95cb324adbb8f78db096aac2874ded0504e65dba Cr-Commit-Position: refs/heads/master@{#31976}

Patch Set 1 #

Patch Set 2 : A bit of cement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -196 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +159 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 8 chunks +0 lines, -148 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 30 chunks +48 lines, -41 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-11-12 14:45:14 UTC) #3
Benedikt Meurer
LGTM
5 years, 1 month ago (2015-11-12 15:00:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439473003/20001
5 years, 1 month ago (2015-11-13 08:08:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-13 08:12:10 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95cb324adbb8f78db096aac2874ded0504e65dba
Cr-Commit-Position: refs/heads/master@{#31976}

Powered by Google App Engine
This is Rietveld 408576698