Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143943020: Replace [TreatNullAs=functionName] with [StrictTypeChecking] (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

Replace [TreatNullAs=functionName] with [StrictTypeChecking] There's a very weird use of [TreatNullAs=functionName] and [TreatUndefinedAs=functionName] on 2 indexed setters, using these as "function to call on undefined/null", basically to call a deleter on undefined/null. This can be removed by just putting this deleter code in the setter code, and then moving the type-checking into the bindings, where they belong. This simplifies the Blink code, CG, and IDL files, and also adds support for [StrictTypeChecking], for that matter. (Also removed dead code from named property setter.) Also: * Rebaseline test results for HTMLSelectElement, since error message changes * Add test for HTMLOptionsCollection (which lacks tests), and fix style in that file. * Update IDL test files Originally added as part of: Support indexed setter generation https://chromiumcodereview.appspot.com/15899009 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166210

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update tests, Python, and IDLExtendedAttributes.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -80 lines) Patch
M LayoutTests/fast/dom/HTMLOptionElement/collection-setter-getter.html View 1 2 1 chunk +26 lines, -15 lines 0 comments Download
M LayoutTests/fast/dom/HTMLOptionElement/collection-setter-getter-expected.txt View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/exceptions-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/IDLExtendedAttributes.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 2 2 chunks +10 lines, -25 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestEventTarget.idl View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 1 chunk +2 lines, -9 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-01-30 11:08:15 UTC) #1
haraken
LGTM. This is nice clean-up.
6 years, 10 months ago (2014-01-30 11:12:27 UTC) #2
Nils Barth (inactive)
On 2014/01/30 11:12:27, haraken wrote: > LGTM. This is nice clean-up. Thanks! (#^_^#)
6 years, 10 months ago (2014-01-30 11:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/143943020/40001
6 years, 10 months ago (2014-01-31 02:53:20 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10145
6 years, 10 months ago (2014-01-31 05:59:54 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 05:59:56 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 06:00:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/143943020/40001
6 years, 10 months ago (2014-01-31 06:02:20 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24871
6 years, 10 months ago (2014-01-31 08:20:54 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 08:20:57 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 08:20:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/143943020/40001
6 years, 10 months ago (2014-01-31 08:22:24 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24945
6 years, 10 months ago (2014-01-31 11:36:57 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 11:37:02 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 11:37:06 UTC) #15
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-01-31 12:40:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/143943020/40001
6 years, 10 months ago (2014-01-31 12:40:52 UTC) #17
commit-bot: I haz the power
Change committed as 166210
6 years, 10 months ago (2014-01-31 13:29:32 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 13:29:33 UTC) #19
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 13:29:40 UTC) #20
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698