Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 143943009: add leaks flag to show unref'd insts (Closed)

Created:
6 years, 11 months ago by caryclark
Modified:
6 years, 11 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

add leaks flag to show unref'd insts Leaks are shown optionally instead of always for tests, gm, and bench. The current display does not show actual leaks necessarily, but shows global objects that were not deleted when the test ended. To enable the end-of-run leak display, pass --leaks or -l. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13151

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M bench/benchmain.cpp View 2 chunks +5 lines, -2 lines 1 comment Download
M gm/gmmain.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M tests/skia_test.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
6 years, 11 months ago (2014-01-23 15:09:51 UTC) #1
mtklein
lgtm https://codereview.chromium.org/143943009/diff/1/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/143943009/diff/1/bench/benchmain.cpp#newcode298 bench/benchmain.cpp:298: gPrintInstCount = true; Even, gPrintInstCount = FLAGS_leaks;
6 years, 11 months ago (2014-01-23 15:24:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/143943009/1
6 years, 11 months ago (2014-01-23 16:05:46 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 17:21:24 UTC) #4
Message was sent while issue was closed.
Change committed as 13151

Powered by Google App Engine
This is Rietveld 408576698