Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1439403002: Fix to suppress (redundant) parse error reporting. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 0c32ebfb50cbf7ddad72490aa9dc2c444d087a8b..7bce28518867543ab825752d55f1db34a16aec2c 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -470,16 +470,8 @@ class ContextManagerImpl implements ContextManager {
Map<String, YamlNode> options;
try {
options = analysisOptionsProvider.getOptions(folder);
- } catch (e, stacktrace) {
- AnalysisEngine.instance.logger.logError(
- 'Error processing .analysis_options',
- new CaughtException(e, stacktrace));
- // TODO(pquitslund): contribute plugin that sends error notification on
- // options file.
- // Related test:
- // context_manager_test.test_analysis_options_parse_failure()
- // AnalysisEngine.instance.optionsPlugin.optionsProcessors
- // .forEach((OptionsProcessor p) => p.onError(e));
+ } catch (_) {
+ // Parse errors are reported by GenerateOptionsErrorsTask.
}
if (options == null && !optionsRemoved) {
@@ -838,7 +830,7 @@ class ContextManagerImpl implements ContextManager {
return new CustomPackageResolverDisposition(resolver);
}
}
-
+
ServerPerformanceStatistics.pub.makeCurrentWhile(() {
packageMapInfo = _packageMapProvider.computePackageMap(folder);
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698