Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1439353004: Implement JSProxy::GetOwnPropertyDescriptor. (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
neis, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement JSProxy::GetOwnPropertyDescriptor. Next step: expose it to JS and test it. BUG=v8:1543 LOG=n R=cbruni@chromium.org Committed: https://crrev.com/c3688c1aec3a8658271d4d8d248c0b26f7925f9d Cr-Commit-Position: refs/heads/master@{#32006}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -3 lines) Patch
M src/messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 chunks +121 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
Camillo: PTAL. Georg: FYI.
5 years, 1 month ago (2015-11-13 17:58:58 UTC) #1
Camillo Bruni
lgtm with minor nit. https://codereview.chromium.org/1439353004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1439353004/diff/1/src/objects.cc#newcode6814 src/objects.cc:6814: Handle<Object> args[] = {target, it->GetName()}; ...
5 years, 1 month ago (2015-11-16 10:54:06 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/1439353004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1439353004/diff/1/src/objects.cc#newcode6814 src/objects.cc:6814: Handle<Object> args[] = {target, it->GetName()}; On 2015/11/16 10:54:06, cbruni ...
5 years, 1 month ago (2015-11-16 11:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439353004/20001
5 years, 1 month ago (2015-11-16 11:40:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-16 11:59:40 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 12:00:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3688c1aec3a8658271d4d8d248c0b26f7925f9d
Cr-Commit-Position: refs/heads/master@{#32006}

Powered by Google App Engine
This is Rietveld 408576698